[[FIX]] Always warn about missing "use strict" directive

Fixes gh-2668
jshint · Sep 20, 2015 · e85c2a1 · e85c2a1
1 parent 5c96bf8
commit e85c2a1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/jshint.js b/src/jshint.js
@@ -1671,7 +1671,9 @@ var JSHINT = (function() {
 
     r = expression(0, true);
 
-    if (r && (!r.identifier || r.value !== "function") && (r.type !== "(punctuator)")) {
+    if (r && !(r.identifier && r.value === "function") &&
+        !(r.type === "(punctuator)" && r.left &&
+          r.left.identifier && r.left.value === "function")) {
       if (!state.isStrict() &&
           state.option.strict === "global") {
         warning("E007");

diff --git a/tests/unit/options.js b/tests/unit/options.js
@@ -1651,6 +1651,10 @@ exports.strict = function (test) {
     .addError(1, 'Use the function form of "use strict".')
     .test(code3, { strict: "func", node: true });
 
+  TestRun(test, "gh-2668")
+    .addError(1, "Missing \"use strict\" statement.")
+    .test("a = 2;", { strict: "global" });
+
   test.done();
 };
 
@@ -1684,6 +1688,7 @@ exports.globalstrict = function (test) {
   ];
   TestRun(test)
     .addError(1, 'Missing "use strict" statement.')
+    .addError(2, 'Missing "use strict" statement.')
     .test(code, { globalstrict: true, strict: true });
 
   // globalscript does not prevent you from using only the function-mode

diff --git a/tests/unit/parser.js b/tests/unit/parser.js
@@ -6960,6 +6960,7 @@ exports.testStrictDirectiveASI = function (test) {
     .test("'use strict'\n(function fn() {})();", options);
 
   TestRun(test, 5)
+    .addError(2, "Missing \"use strict\" statement.")
     .test("'use strict'\n[0] = '6';", options);
 
   TestRun(test, 6)
@@ -6969,6 +6970,7 @@ exports.testStrictDirectiveASI = function (test) {
     .test("'use strict',function fn() {}\nfn();", options);
 
   TestRun(test, 7)
+    .addError(1, "Missing \"use strict\" statement.")
     .test("'use strict'.split(' ');", options);
 
   TestRun(test, 8)