Parse yield expressions. #1109
Closed
Parse yield expressions. #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Warn about yield expressions needing parentheses in `moz: true` code.
- The paren warning should be at the `yield` location.
- `yield` should have higher precedence than assign ops.
This also makes sure bitwise assign ops are also tagged with `assign`.
Anything with `nud` should return a value from `expression(10)`.
This is a little tricky:
```js
function f() {
// okay because it actually parses as
// yield (a ? b : c);
yield a ? b : c;
// needs paren
yield ? b : c;
// okay
a ? yield : yield;
// needs paren for the second `yield`
a ? yield : yield ? yield : yield;
}
```
I might be able to use `token.reach` here.
- Don't test line-breaking here. It confuses the issue.
This prevents getting warnings referring to "(number)" instead of "42".
|
Thanks! |
valueof
pushed a commit
that referenced
this pull request
Jun 26, 2013
|
@usrbincc I've started using your commits. It fixes most of the yield complains this is awesome! One thing it still complains about is |
jugglinmike
pushed a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 21, 2014
Also fixed jshint#387. Also fixed jshint#1108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this patch consists of code to determine whether or not Mozilla needs parens around
yieldin a given situation. Mozillayieldparsing has some serious quirks, and I can't be certain I got them all.Mozilla needing parens for
yieldseems to be only partially based on precedence. The rest of it seems to be based on some semi-random sense of aesthetics. It makes me curious as to what their parsing code is actually doing. Not quite curious enough to check, but almost.Fixes #387. The bug there was that jshint was only checking for the end of expression once, and not per-loop. There was some incompleteness in the checking condition, too. Hopefully I got everything.
Fixes #1108. Comma expressions were using the default whitespace checking for
infix, which in addition to being wrong, also conflicted with the comma-specific whitespace checking. Fixed by moving all comma whitespace checking over to comma-specific code.jshint currently has no comprehensive tests of whitespace checking, which is how this bug sneaked in in the first place. I'll do this in a follow-up pull.
Sorry about combining these separate bugfixes into one pull request. The #1108 fix could have conceivably been done separately, but it would have been impossible to parse yield expressions properly without the #387 fix.