Fix finding config file for /dev/stdin #1194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cybercase
added a commit
to cybercase/jshint
that referenced
this pull request
Sep 29, 2013
In Documentation/Configuration, first paragraph, is stated that: "JSHint will look for this file in the current working directory and, if not found, will move one level up the directory tree all the way up to the filesystem root." (note: "this file" = ".jshintrc") Ref: http://www.jshint.com/docs/config/ But this is not true if input is coming from stdin. This patch address this unexpected behaviour by calling function findConfig even when the input is coming from stdin.
jugglinmike
pushed a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 21, 2014
Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1165