Rhino Wrapper: Globals & Exitcode #1197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
pushed a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 21, 2014
…package. Signed-off-by: Anton Kovalyov <anton@kovalyov.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues I have come across.
1.) Exit Code behaviour differed between the Node-CLI Version of JSHint and the Rhino Wrapper. "JSHint ran fine, but you have lints" now exits with 2 on rhino as well.
2.) When linting multiple files at once, JSHint "forgot" the configured globals from the second file on, This Patch introduces the globals as the third argument to JSHINT( input, opts, globals), rather than relying on "opts.predef". This Behaviour was also taken from the Cli-Wrapper.