Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[FIX]] template tokens are not infix operators #2224

Closed
wants to merge 1 commit into from
Closed

[[FIX]] template tokens are not infix operators #2224

wants to merge 1 commit into from

Conversation

caitp
Copy link
Member

@caitp caitp commented Feb 28, 2015

Closes #2223
Closes #2224

@caitp
Copy link
Member Author

caitp commented Feb 28, 2015

I think this is okay (might even allow getting rid of the special casing... lets see... nope ._.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.31% when pulling 952ccab on caitp:issue-2223 into 983fc8d on jshint:master.

@caitp
Copy link
Member Author

caitp commented Feb 28, 2015

so I think this is correct, since a template is an operand and not an operator.

@caitp caitp closed this in 162dee6 Feb 28, 2015
@ruimarinho
Copy link

Thank you for landing this @caitp :) @rwaldron any chance of releasing this on a patch release?

jugglinmike pushed a commit to jugglinmike/jshint that referenced this pull request Mar 15, 2015
@caitp @jugglinmike
[[FIX]] templates are operands, not operators
3eb23c4 
Closes jshint#2223
Closes jshint#2224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tagged template literal multiline return with function call fails
3 participants
@caitp @coveralls @ruimarinho