[[FIX]] parse const declarations in ForIn/Of loops
#2335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4189,8 +4189,8 @@ var JSHINT = (function() { | |||
| if (state.tokens.next.id === "var") { | |||
| advance("var"); | |||
| state.tokens.curr.fud({ prefix: true }); | |||
| } else if (state.tokens.next.id === "let") { | |||
| advance("let"); | |||
| } else if (state.tokens.next.id === "let" || state.tokens.next.id === "const") { | |||
There was a problem hiding this comment.
TODO: should only be treating let/const specially if esnext es3 or es5 mode is used
|
self-reviewed, think it should wait on fixing the behaviour of |
|
I'm mobile atm so can't compare with #2326 is there any overlap? (Sorry if that seems lazy) |
|
not that I can see in the diff |
|
it looks like coveralls.io is having issues |
|
I don't think it conflicts with my pr :) |
|
it's not conflicts that's the worry, it's that the behaviour of |
|
Im working on it - i have work i havent pushed yet as well. If you can
review my pr (im building on top of it so sooner the better for code
review) and get them both in, that would help and i can create my next pr.
If you know of anything const specific (next pr is for latedef and unused
of block scope, so let too) thats very broken and not fixed by this and my
pr, please let me know.
|
jugglinmike
pushed a commit
to jugglinmike/jshint
that referenced
this pull request
May 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2334