Add a check for unnecessary use of call?

[chrisprice]

Given -

var a = {
b: function() {}
};

Should the following code not trigger a warning about the unnecessary use of call?

a.b.call(a);

(I think the above is exactly equivalent to - a.b();)

If so the check should probably be generalised to n arguments.

[valueof]

What is the reasoning behind this? Just overall code cleanliness or something bigger? If former, we'll make it possible to extend JSHint for such cases soon. If latter, please send a patch.

[chrisprice]

It was the former, I had just being reviewing some code and it stood out to me as a good candidate for a warning. a.b.call(a) suggests to me that the author has not fully understood when it is appropriate to use call.

I suppose the same check should also be applied for -

a.b.apply(a, [c...]) equivalent to a.b(c...)
a.b.apply(a) equivalent to a.b()
a.b.call(a, c...) equivalent to a.b(c...)
a.b.call(a) equivalent to a.b()

[chrisprice]

FYI, JSLint now warns as I suggested -

http://tech.groups.yahoo.com/group/jslint_com/message/3004