Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhino version and require #739

Closed
patwork opened this issue Nov 10, 2012 · 5 comments
Closed

rhino version and require #739

patwork opened this issue Nov 10, 2012 · 5 comments

Comments

@patwork
Copy link

patwork commented Nov 10, 2012

After commit 6dc73c4 rhino version stopped working, because it doesn't support 'require'.

js: uncaught JavaScript runtime exception: ReferenceError: "require" is not defined.

@valueof
Copy link
Member

valueof commented Nov 10, 2012

Yeah, we will need to update the build command before the next release.

@stereobooster
Copy link

require is not a big problem. It can be resolved with stitch. But there is additinally CommonJS event module required. And don't forget about underscore.

@valueof
Copy link
Member

valueof commented Nov 26, 2012

Basically, what I plan to do is to browserify the whole project and use the result for the web/rhino/jsc/wsh wrappers. Should work fine.

@christianvuerings
Copy link

@antonkovalyov Were you able to do work on this?

@valueof
Copy link
Member

valueof commented Jul 1, 2013

This was fixed.

@valueof valueof closed this as completed Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants