-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for HEIC/HEIF Image Formats #129
Conversation
Did anyone submit the request to the IANA as mentioned in the issue you linked to? |
Hm. I'm sorry, I'm not sure I follow. I don't think there was a reference to the IANA on that issue. |
To get it added, follow steps at https://github.com/jshttp/mime-db#adding-custom-media-types |
Ah, I see. No, as far as I can tell it hasn't been added to IANA, and I don't know enough about the format to make a request myself. I've just encountered the format "in the wild", so was attempting to add a custom type according to Contributing. Apologies for the misunderstanding. Feel free to close if that's the proper course of action. |
Gotcha. Our goal is just to aggregate from the three sources listed in the README (IANA, Apache, NGINX) and simply present it in a nice format. There isn't the manpower nor desire to administrate a source database itself, though (it was tried for a bit, but no longer). Ideally if this really is used it would be in at least one of those three places (especially the IANA, which is the administrator for this exact type of thing). I hope that makes sense. |
Totally does. I'm surprised that this format isn't anywhere, to be honest, as it's the default image format on new iOS devices. Bummer though, going to need to monkeypatch around Feel free to close. Thanks for your time. |
Yea, I would think so too. Technically this module is not the source, just another middleman like |
Ha! Well, I understand that position, but as far as my code is concerned it might as well be the source. I would make an argument that there's value in a strictly-controlled "community" supplement to the official sources, but that's likely because I'm not doing that work. ;) |
Yes, the IANA is a community source, in fact. I'm just one person maintaining this aggregator module, certainly no where close to the definition of a community and no community resources. The IANA form goes to a mailing list with dozens of active folks. |
Great point. Anyways, thanks again for your time. |
From https://tools.ietf.org/html/rfc6838#section-5 :
Formal registrations require an entire procedure, but simply submitting via the form is not the formal process and just a community review process to say either "yep, this looks right! add to database" or bring up some kind of conflict or other issue :) |
fixes jshttp#93 closes jshttp#129 closes jshttp#144
@dougwilson https://www.iana.org/assignments/media-types/media-types.xhtml they seem to have been added in July. Should this PR be re-opened and merged? |
It's been merged. See the commit referenced above your comment. |
Hopefully this is in order. Should resolve #93. Let me know if you need any changes!