Adds an option to change the listen-on address and exposes the UDP connection #38
Conversation
Signed-off-by: Brian Murray <brian@bmurray.ca>
|
Hi! |
|
Sorry about that. Should be good now! |
|
@bmurray Unfortunately the commits are still not shown as signed. Did you add your signing key |
Adds raw access to the node's underlying socket Signed-off-by: Brian Murray <brian@bmurray.ca>
|
I'm pretty new to signing so I didn't realize there was a GPG signing option too. Rather confusing. I was able to sign with a new GPG key. It says verified now, so I think its good. |
node.go
Outdated
| n.SetOption(opt) | ||
| } | ||
|
|
||
| for _, opt := range opts { |
There was a problem hiding this comment.
Why is this code block duplicated?
There was a problem hiding this comment.
Good catch. Must have slipped in while merging. I don't quite know why it thought that was a merge issue on that line... I'll fix it.
Signed-off-by: Brian Murray <brian@bmurray.ca>
|
@bmurray Can you please resolve the conflicts? |
This lets the caller set the IP and Port. Useful on multi-homed servers.
This also exposes the udp connection on a Node, in case one wants to send a raw DMX packet, or otherwise.