add install section to switchbot_ros/CMakeLists.txt #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqcmd196
changed the title
708yamaguchi
requested changes
Oct 28, 2021
There was a problem hiding this comment.
I think file(GLOB SCRIPTS scripts/*) includes scripts/switchbot.l, which is not a python script.
I think install() command is better for euslisp code.
Examples:
https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/df0fc28a965168744c7d2bd1dd57e6fca8fb9d29/pr2eus/CMakeLists.txt#L31-L43
jsk_3rdparty/sesame_ros/CMakeLists.txt
Lines 34 to 36 in e1f1391
sktometometo
requested changes
Oct 28, 2021
sktometometo
approved these changes
Nov 1, 2021
708yamaguchi
approved these changes
Nov 1, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/290/files#r734913651 , I added install section.