[rostwitter] Suppress tweet log #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
reviewed
Sep 3, 2022
rostwitter/scripts/tweet.py
Outdated
| @@ -28,7 +28,7 @@ def __init__(self): | |||
|
|
|||
| def tweet_cb(self, msg): | |||
| message = msg.data | |||
| rospy.loginfo(rospy.get_name() + " sending %s", message) | |||
| rospy.logdebug(rospy.get_name() + " sending %s", message) | |||
There was a problem hiding this comment.
if loginfo is not noisy without bsae64 message, how abotut use loginfo + something like ' '.join([a if len(a) < 32 else a[0:32]+'...' for a in txt.split(' ')]) ?
If we already feel darty without base64, using logdebug make sense
There was a problem hiding this comment.
Thank you for advice. I think loginfo is not noisy without base64 message.
So, I fixed it in 6451728
k-okada
added a commit
to k-okada/jsk_3rdparty
that referenced
this pull request
Dec 15, 2022
knorth55
pushed a commit
to knorth55/jsk_3rdparty
that referenced
this pull request
Dec 15, 2022
knorth55
pushed a commit
to knorth55/jsk_3rdparty
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates of knorth55#33
This PR suppresses tweet log.
If Base64 encoding texts are displayed in logs, logs are too dirty to see.