[jsk_data] add YAML topic savetype #1476
Conversation
| @@ -119,6 +127,9 @@ def service_cb(self, req): | |||
| bridge = cv_bridge.CvBridge() | |||
| label = bridge.imgmsg_to_cv2(msg) | |||
| cv2.imwrite(osp.join(save_dir, topic['fname']), label) | |||
| elif topic['savetype'] == 'Text': | |||
There was a problem hiding this comment.
Why not use YAML save type?
In [1]: from std_msgs.msg import String
In [2]: msg = String(data='spam')
In [3]: import genpy
In [4]: genpy.message.strify_message(msg)
Out[4]: 'data: spam'
In [5]: from sensor_msgs.msg import FluidPressure
In [6]: msg = FluidPressure(fluid_pressure=1080, variance=0)
In [7]: msg.header.frame_id = 'right_vacuum_gripper'
In [8]: genpy.message.strify_message(msg)
Out[8]: 'header: \n seq: 0\n stamp: \n secs: 0\n nsecs: 0\n frame_id: right_vacuum_gripper\nfluid_pressure: 1080\nvariance: 0'
In [9]: print(genpy.message.strify_message(msg))
header:
seq: 0
stamp:
secs: 0
nsecs: 0
frame_id: right_vacuum_gripper
fluid_pressure: 1080
variance: 0| self.msg[topic_name] = msg | ||
| else: | ||
| self.msg[topic_name] = msg | ||
| self.msg_received_time[topic_name] = rospy.Time.now() |
There was a problem hiding this comment.
Why not use below?
self.msg[topic_name] = {
'stamp': msg.header.stamp if msg._has_header else rospy.Time.now(),
'msg': msg,
}
knorth55
changed the title
|
thx, fixed |
|
PR is tottaly modified to save msg in YAML file, and merged #1475 PR |
| @@ -86,7 +87,10 @@ def __del__(self): | |||
| sub.unregister() | |||
|
|
|||
| def sub_cb(self, msg, topic_name): | |||
| self.msg[topic_name] = msg | |||
| self.msg[topic_name] = { | |||
| 'stamp': msg.header.stamp if msg._has_header else rospy.Time.now(), | |||
There was a problem hiding this comment.
are there any reasons you use 8 spaces? why not 4 spaces?
There was a problem hiding this comment.
no reason for 8 spaces, but no reason for 4 spaces because there is no lint error.
i read python style code, and it says continuous line indent is optional rule, which i didn't know.
There was a problem hiding this comment.
I don't think linter is perfect, and I think it needs human help.
Do you think it is ok if you add 100 spaces over there?
There is no linter error, but it should be fixed, isn't it?
There was a problem hiding this comment.
i fixed indent in #1480
support no-header message
add YAML topic savetype