Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_network_tools] add skip_interfaces param in network_status.py #1664

Merged
merged 2 commits into from
Nov 30, 2020
Merged

[jsk_network_tools] add skip_interfaces param in network_status.py #1664

merged 2 commits into from
Nov 30, 2020

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Nov 20, 2020 •
edited

this PR adds ~skip_interfaces param in jsk_network_tools/network_status.py
You can specify skipping interfaces as follows:

<launch>
  <node name="network_status" pkg="jsk_network_tools" type="network_status.py">
    <rosparam>
      skip_interfaces:
        - docker0
        - lo
        - eno2
    </rosparam>
  </node>
</launch>

I also add doc for jsk_network_tools/network_status.py

network_status

@knorth55 knorth55 changed the title add skip_interfaces param in network_status.py [jsk_network_tools] add skip_interfaces param in network_status.py Nov 20, 2020
@knorth55 knorth55 mentioned this pull request Nov 20, 2020
Merged
708yamaguchi
708yamaguchi approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can use this feature on fetch1075.

@knorth55
Copy link
Member Author

I need this PR to use network_status.py in PR2 to skip ecat0 ethercat device check.
Travis passed. @k-okada can you merge this PR?

@k-okada k-okada merged commit b764ab7 into jsk-ros-pkg:master Nov 30, 2020
@knorth55 knorth55 deleted the network-status-skip-interfaces branch November 30, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@708yamaguchi 708yamaguchi 708yamaguchi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knorth55 @708yamaguchi @k-okada