[jsk_tools] Seperate sanity check frequency and diagnostics publish frequency #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR, sanity diagnostics are always shown on PR1040, fetch15 and fetch1075 rqt robot monitor. |
|
I checked the following branch and it worked well. |
iory
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
sanity diagnostics status in rqt_robot_monitor turns on and off.
What I did
In this PR, I separate topic and node check frequency and diagnostics publish frequency.
Currently, when I run
roslaunch jsk_tools sample_sanity_diagnostics.launch,/diagnosticstopic is published at more than 1 Hz butcheck_topic()andcheck_node()methods are called at 0.1 Hz.