[jsk_topic_tools] Add header file to check jsk_topic_tools' version #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knorth55
requested changes
Jul 14, 2022
knorth55
approved these changes
Jul 14, 2022
k-okada
reviewed
Jul 15, 2022
| @@ -31,6 +31,21 @@ configure_file( | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/include/jsk_topic_tools/nodelet_version.h.in | |||
| ${CATKIN_DEVEL_PREFIX}/${CATKIN_GLOBAL_INCLUDE_DESTINATION}/jsk_topic_tools/nodelet_version.h) | |||
|
|
|||
| catkin_package_xml() | |||
There was a problem hiding this comment.
sorry, I think it safe to put configure_file after catkin_package so that we do not need to use catkin_package_xml, because I suppose catkin_package_xml is not designed to used in User's program. how do you think? @iory
There was a problem hiding this comment.
I see. That's good for users.
https://github.com/ros/catkin/blob/2612c4ce82a285cac13263576f8a85b8a6d6cd3d/cmake/catkin_package.cmake#L97-L100
catkin_package internally calls catkin_package_xml.
I created a PR #1755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
I add
version.hforjsk_topic_toolsto check version for build.jsk_topic_toolshas base class such asDiagnosticNodeletandConnectionBasedNodelet.For example, nodes in
jsk_recognitionare using those notelets.This PR is useful to check
jsk_topic_toolsversion.Related to jsk-ros-pkg/jsk_recognition#2712