Fix missing pkg_name in install_sample_data.py #2267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pkg_name
argument is required.And
./install_sample_data.py
fails...Why this happens?
Because of the merge commit.
You can see
git show 338d9b850623cb614eb5596fba9c6b7ff1e2b9c9
.The git log says @k-okada triggered
git merge
in #1991,and this bug was introduced.
I'm not sure this is caused by the failure of auto git-merge or mistaken conflict resolving.
Do you remember something? @k-okada @furushchev