[jsk_perception] Add human mesh recovery(estimate people 3d pose from 2d image) #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iory
force-pushed
the
human-mesh-recovery
branch
from
6246c0a
to
e1875f4
Compare
|
Works well on my environment! |
|
if you care about style, please add them within cmake/travis
--
◉ Kei Okada
2018年10月30日(火) 16:08 Yuto Uchimi <notifications@github.com>:
… Works well on my environment!
@iory <https://github.com/iory> Could you please refactor code for
flake8+hacking or at least pep8?
$ flake8 node_scripts/human_mesh_recovery.py
node_scripts/human_mesh_recovery.py:16:1: H306 imports not in alphabetical order (tf, cv_bridge)
node_scripts/human_mesh_recovery.py:19:1: H306 imports not in alphabetical order (rospy, jsk_topic_tools.connectionbasedtransport)
node_scripts/human_mesh_recovery.py:20:1: H306 imports not in alphabetical order (jsk_topic_tools.connectionbasedtransport, geometry_msgs.msg.pose)
node_scripts/human_mesh_recovery.py:21:1: H306 imports not in alphabetical order (geometry_msgs.msg.pose, geometry_msgs.msg.point)
node_scripts/human_mesh_recovery.py:28:1: H306 imports not in alphabetical order (hmr.smpl.smpl, hmr.net.encoderfc3dropout)
node_scripts/human_mesh_recovery.py:113:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:114:80: E501 line too long (80 > 79 characters)
node_scripts/human_mesh_recovery.py:115:80: E501 line too long (82 > 79 characters)
node_scripts/human_mesh_recovery.py:116:80: E501 line too long (80 > 79 characters)
node_scripts/human_mesh_recovery.py:117:80: E501 line too long (80 > 79 characters)
node_scripts/human_mesh_recovery.py:118:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:119:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:120:80: E501 line too long (80 > 79 characters)
node_scripts/human_mesh_recovery.py:121:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:122:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:123:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:124:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:125:80: E501 line too long (82 > 79 characters)
node_scripts/human_mesh_recovery.py:126:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:127:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:128:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:129:80: E501 line too long (88 > 79 characters)
node_scripts/human_mesh_recovery.py:146:80: E501 line too long (85 > 79 characters)
node_scripts/human_mesh_recovery.py:170:80: E501 line too long (87 > 79 characters)
node_scripts/human_mesh_recovery.py:250:80: E501 line too long (81 > 79 characters)
node_scripts/human_mesh_recovery.py:256:80: E501 line too long (102 > 79 characters)
node_scripts/human_mesh_recovery.py:264:80: E501 line too long (102 > 79 characters)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2332 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3K7UGxMmzyVhn8OPY_GiHi7Ek90rks5up_sFgaJpZM4Wo_gK>
.
|
|
@YutoUchimi @YutoUchimi @k-okada style test on travis. |
YutoUchimi
approved these changes
Oct 30, 2018
|
I did not say we SHOULD add them. If I ware you, I will not want ask
everyone to spend time on eliminating code from 81 char to 79....
…--
◉ Kei Okada
2018年10月30日(火) 16:28 iory <notifications@github.com>:
@YutoUchimi <https://github.com/YutoUchimi>
Thanks for your review! I refactored this PR's code.
@YutoUchimi <https://github.com/YutoUchimi> @k-okada
<https://github.com/k-okada>
Also I agree with
if you care about style, please add them within cmake/travis
style test on travis.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2332 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3NPY7aVNnCC_Vjo7xiDqOJkKtX7Zks5up_-GgaJpZM4Wo_gK>
.
|
|
Hmm... I wouldn't fix all existing codes, either. Anyway, @iory thanks for updating! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementation of End-to-end Recovery of Human Shape and Pose (
https://arxiv.org/abs/1712.06584).This node estimates the 3d pose of human from 2d image.
Please also see document file here (https://github.com/iory/jsk_recognition/blob/bbf2b3504772b4c1524d1db9dd035fa4fe23c9b0/doc/jsk_perception/nodes/human_mesh_recovery.rst)
Following gif is example of estimated 3d poes and input images.