-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[audio_to_spectrogram] Enable publishing frequency vs amplitude plot #2654
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
14b26e5
[audio_to_spectrogram] Enable publishing frequency vs amplitude plot
iory 7593773
[audio_to_spectrogram] Add docs for spectrum_plot.py
iory ba1a312
[audio_to_spectrogram] Delete debug print
iory 2ba1db6
[audio_to_spectrogram] Use ConnectionBasedTransport
iory 6f29d0c
[audio_to_spectrogram] Fixed typo unsupported -> unsubscribe
iory 2af9fed
[audio_to_spectrogram] Move spectrum_plot.py node outside of gui option.
iory 4601d67
[audio_to_spectogram] Add example spectrum image to docs
iory bf7c688
[audio_to_spectogram] convert_matplotlib_to_img as a library
iory File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
from .audio_buffer import AudioBuffer | ||
from .convert_matplotlib import convert_matplotlib_to_img |
19 changes: 19 additions & 0 deletions
19
audio_to_spectrogram/src/audio_to_spectrogram/convert_matplotlib.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
try: | ||
# for python2.x | ||
from StringIO import StringIO as BufIO | ||
except ModuleNotFoundError: | ||
# for python3.x | ||
from io import BytesIO as BufIO | ||
|
||
import numpy as np | ||
import PIL | ||
|
||
|
||
def convert_matplotlib_to_img(fig): | ||
buf = BufIO() | ||
fig.savefig(buf, format="png") | ||
buf.seek(0) | ||
img = np.array( | ||
PIL.Image.open(buf), dtype=np.uint8) | ||
img = img[..., :3] | ||
return img |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using
ConnectionBasedTransport
?https://jsk-docs.readthedocs.io/projects/jsk_common/en/latest/jsk_topic_tools/class/python_connection_based_transport.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good idea, thanks. I modified the code. 2e86235