PR/add jsk aibo robot #1852
Open
PR/add jsk aibo robot #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sktometometo
requested changes
Sep 16, 2023
| @@ -0,0 +1,71 @@ | |||
| 1694083040310 geckodriver INFO Listening on 127.0.0.1:36887 | |||
There was a problem hiding this comment.
In order to keep the code base minimal, files that are generated later, such as log files, generally speaking, should not be included in the git repository.
There was a problem hiding this comment.
@a-ichikura Could you update jsk_aibo_robot/aibo_selenium_ros/.gitignore so that this file will not be added to git repo?
| if chrome_executable_path is not None: | ||
| options.binary_location = chrome_executable_path | ||
|
|
||
| self.driver = uc.Chrome(executable_path=webdriver_path, options=options, version_main=115) |
There was a problem hiding this comment.
chrominum version is different for each system. So it will be convenient if this program retrieve main version from chromium-browser --version command. See 7cbcd36 for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we add
version_mainparameter into init.py because the version of undetected driver should be as same as chrome-driver and chrome-browser. with @sktometometo