Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baxtereus] support tm :fast in moveit angle-vector methods #789

Merged
merged 4 commits into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@knorth55
Copy link
Member

commented Jun 13, 2017

Requires jsk-ros-pkg/jsk_pr2eus#297

Changes

  • support tm :fast in moveit :angle-vector and :angle-vector-sequence methods

Minor Changes

  • update doc

@knorth55 knorth55 requested a review from pazeshun Jun 13, 2017

@knorth55 knorth55 changed the title Support tm fast [baxtereus] support tm :fast in moveit angle-vector methods Jun 13, 2017

@knorth55

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2017

Add test for angle-vector-sequence and tm :fast.
Currently, test fails because of jsk-ros-pkg/jsk_pr2eus#297.

@knorth55

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2017

waiting for upstream release.

@knorth55

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2017

Update and follow #791 (review)

@knorth55 knorth55 force-pushed the knorth55:support-tm-fast branch from 7f3d247 to 1668ad6 Jun 22, 2017

@k-okada

This comment has been minimized.

Copy link
Member

commented Jun 22, 2017

what do you think if we support old API like #795 ? new api (av tm ctype start-time :...) are already used in apc?

@knorth55

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2017

I use new API in order to pass keyword arguments, but start-time is always 0.
I prefer old API, which passes start-time in keyword argument.

@knorth55 knorth55 referenced this pull request Jun 23, 2017

Closed

When is new release? #303

@knorth55

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

@k-okada Test passed! Please merge this.

@k-okada k-okada merged commit ec22898 into jsk-ros-pkg:master Jun 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@knorth55 knorth55 deleted the knorth55:support-tm-fast branch Jun 28, 2017

@wkentaro wkentaro added this to the 1.0.10 milestone Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.