Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[baxtereus] support tm :fast in moveit angle-vector methods #789

Merged
merged 4 commits into from
Jun 28, 2017
Merged

[baxtereus] support tm :fast in moveit angle-vector methods #789

merged 4 commits into from
Jun 28, 2017

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Jun 13, 2017 •
edited
Loading

Requires jsk-ros-pkg/jsk_pr2eus#297

Changes

  • support tm :fast in moveit :angle-vector and :angle-vector-sequence methods

Minor Changes

  • update doc

@knorth55 knorth55 requested a review from pazeshun June 13, 2017 15:57
@knorth55 knorth55 changed the title Support tm fast [baxtereus] support tm :fast in moveit angle-vector methods Jun 13, 2017
@knorth55
Copy link
Member Author

Add test for angle-vector-sequence and tm :fast.
Currently, test fails because of jsk-ros-pkg/jsk_pr2eus#297.

@knorth55
Copy link
Member Author

knorth55 commented Jun 19, 2017 •
edited
Loading

waiting for upstream release.

@knorth55
Copy link
Member Author

Update and follow #791 (review)

@k-okada
Copy link
Member

k-okada commented Jun 22, 2017 •
edited
Loading

what do you think if we support old API like #795 ? new api (av tm ctype start-time :...) are already used in apc?

@knorth55
Copy link
Member Author

knorth55 commented Jun 22, 2017 •
edited
Loading

I use new API in order to pass keyword arguments, but start-time is always 0.
I prefer old API, which passes start-time in keyword argument.

@knorth55 knorth55 mentioned this pull request Jun 23, 2017
Closed
@knorth55
Copy link
Member Author

@k-okada Test passed! Please merge this.

@k-okada k-okada merged commit ec22898 into jsk-ros-pkg:master Jun 28, 2017
@knorth55 knorth55 deleted the support-tm-fast branch June 28, 2017 05:09
@wkentaro wkentaro added this to the 1.0.10 milestone Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazeshun pazeshun pazeshun approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@knorth55 @k-okada @pazeshun @wkentaro