Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pinocchio features #14

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Update Pinocchio features #14

merged 1 commit into from
Oct 31, 2018

Conversation

jcarpent
Copy link
Contributor

No description provided.

jslee02
jslee02 requested changes Oct 31, 2018
View reviewed changes
Copy link
Owner

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! One suggestion though. Could we change the link to the website of pinoccio instead of the repository?

@jslee02
Copy link
Owner

jslee02 commented Oct 31, 2018

Also, according to the repository, the license of the library is still LGPL-3.0. Am I missing something here?

@jcarpent
Copy link
Contributor Author

I will keep the Pinocchio website even if it is not up to date.

@jcarpent
Copy link
Contributor Author

Concerning the license, we are changing from LGPL-3.0 to BSD-2-Clause. See stack-of-tasks/pinocchio#549 for further details.

jslee02
jslee02 approved these changes Oct 31, 2018
View reviewed changes
Copy link
Owner

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. Looks good to me now!

@jslee02 jslee02 merged commit 2758bc8 into jslee02:master Oct 31, 2018
@jcarpent
Copy link
Contributor Author

jcarpent commented Nov 1, 2018

Thanks for the merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslee02 jslee02 jslee02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcarpent @jslee02