Bug report: Fart function with destructuring

[nikoskalogridis]

Describe the bug
Wondering what is the violation of using a fart function here

2. Jslint edition:

v2021.12.20

3. Code snippet (if applicable):

export default Object.freeze({
    pickOne: ({one}) => one
});

Expected behavior
Should allow usage of fart function

[kaizhu256]

its a long-running bug that jslint crashes with cryptic-warnings when parsing fat-arrows that are anything but toy-case. the crashing-and-cryptic-warning-part should ideally be fixed, when maintainers find the time to do so.

whether destructuring in fat-arrows should be tolerated however, is up to debate.

[nikoskalogridis]

Thank you for your quick response.

I cannot think of any issues with destructuring a parameter on a fart function but if that is to be avoided I guess there should be a mention on the help page.

Probably when jslint gets smarter it might produce a more helpful error message.

[kaizhu256]

should be fixed by following 2 pr's:

• pr - bugfix - fix warnings against destructured fart #385

  • fix bugs related to how jslint detect fat-arrows (sometimes it gives false-positives).

• pr - bugfix - make fart-related warnings more readable #386

  • jslint already had existing routines to warn against destructuring (which are the ones you find confusing).
  • the old warnings are replaced with something less cryptic:

// old warning
Expected 'function' before '('.
    pickOne: ({one}) => one
Expected '{' and instead saw '=>'.
    pickOne: ({one}) => one

// new warning
Use 'function (...)', not '(...) =>' when arrow functions become too complex.
    pickOne: ({one}) => one