This repository has been archived by the owner on Jan 9, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bedrock we change the less files a lot,
and have a lot of them. In reading the jingo_minify
code it looked to me like a change to any CSS file
would invalidate all CSS, and the same was true
for js. In my local tests though they seemed to all
be invalidated for every commit. So our long Expires
headers for our media don't do us much good because
all JS and CSS is invalidated on every push, and we
push a few times per week.
The concatinated files are already hashed every time
compress_assets is run to check for sameness. Why not
add those hashes for all bundles to the BUNDLE_HASHES
dict in build.py. The helpers already use it.
I wanted to submit some tests with this as well but
compress_assets is thus for untested. I hope to add
some tests for this command in a subsequent PR.