Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial input #4

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Remove initial input #4

merged 1 commit into from
Jan 3, 2022

Conversation

jsok
Copy link
Owner

@jsok jsok commented Jan 3, 2022

This is a breaking change.
svu v1.9.0 now assumes an initial version of 0.0.0, so rely on
that functionality instead.
Removing initial also means you cannot start at a version other than
0.0.0 either.

This is a breaking change.
svu v1.9.0 now [assumes an initial version of 0.0.0][0-ver], so rely on
that functionality instead.
Removing `initial` also means you cannot start at a version other than
0.0.0 either.

[0-ver]: caarlos0/svu#43
@jsok jsok merged commit 54676a3 into main Jan 3, 2022
@jsok jsok deleted the remove-initial branch January 3, 2022 22:09
@ahaasler
Copy link

Why not a major if this is a breaking change?

@jsok
Copy link
Owner Author

jsok commented Apr 13, 2022

This was, hence a 2.0.0 release of the action.

@ahaasler
Copy link

Sorry, though this was an issue in svu, not the action, my bad.

@jsok
Copy link
Owner Author

jsok commented Apr 13, 2022

FYI I've opened caarlos0/svu#57 to hopefully make this functionality more flexible.

Hope this action has been helpful :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants