Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Assume an initial version of 0.0.0 if no initial version is found #43

Merged
merged 4 commits into from
Nov 17, 2021

Conversation

drewstinnett
Copy link
Contributor

Open to changes here for sure, but this is an attempt to get an initial version set up when no version tags have been found. Meant to address #29

@dfreilich
Copy link

Is there any progress on this? I'd love to see this in it

@drewstinnett
Copy link
Contributor Author

Oops, had a couple conflicts, but resolved now! pinging @caarlos0 to see if this is lining up with what he's thinking on #29 . Happy to refactor as needed

@caarlos0 caarlos0 merged commit 0b3a780 into caarlos0:master Nov 17, 2021
@caarlos0
Copy link
Owner

Thanks!

jsok added a commit to jsok/svu-version-bump-action that referenced this pull request Jan 3, 2022
This is a breaking change.
svu v1.9.0 now [assumes an initial version of 0.0.0][0-ver], so rely on
that functionality instead.
Removing `initial` also means you cannot start at a version other than
0.0.0 either.

[0-ver]: caarlos0/svu#43
jsok added a commit to jsok/svu-version-bump-action that referenced this pull request Jan 3, 2022
This is a breaking change.
svu v1.9.0 now [assumes an initial version of 0.0.0][0-ver], so rely on
that functionality instead.
Removing `initial` also means you cannot start at a version other than
0.0.0 either.

[0-ver]: caarlos0/svu#43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants