Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status and version number? #22

Closed
roypardi opened this issue Mar 6, 2018 · 4 comments
Closed

Status and version number? #22

roypardi opened this issue Mar 6, 2018 · 4 comments
Projects
Official 1.0.0 Release

Comments

@roypardi
Copy link
Contributor

roypardi commented Mar 6, 2018

Hi – nice to see this project getting some attention.

I'm confused about the version numbers: the jdorn most recent version is 7.28 - same as the version in the dist folder here. Was this an oversight or am I looking at the wrong branch (or something)?
@schmunk42
Copy link
Collaborator

Latest version of jdorn is 0.7.28, btw.

I had some issues with PRs and builds in the dist folder, see also #17 (comment)

I'd suggest to remove it and only add it for releases.

You might give develop a try, but you need to run npm run build to create the files in dist.

marc7000 referenced this issue in marc7000/json-editor Mar 7, 2018
@xvaara
Merge commit '27b611a766daf680f60f8b14779284bd9775175c'
b9ee823 
* commit '27b611a766daf680f60f8b14779284bd9775175c': (44 commits)
  Added selenium tests with mocha
  Revert "Merge branch 'mehmetb-master' into develop"
  Include expanded schemas options to include refs (dmstr-forks#27)
  Add option to have info buttons (dmstr-forks#24)
  Implemented template support for 'rel' property on href's schema jdorn#606 (dmstr-forks#17)
  Update multiple.js (dmstr-forks#21)
  Fixed to expand refs before creating root editor (dmstr-forks#18)
  fix for issue 627 - selectize dropdown causes prop to dissapear - and issue 538 - create hardcoded to true (dmstr-forks#19)
  Issue 488 fix disabled fields get enabled when using properties dropdown (dmstr-forks#22)
  Resolved merge conflicts
  update submitted json when editing select fields via json manually to (dmstr-forks#29)
  Copy Array Element Button (dmstr-forks#4)
  Cleaning with innerHTML='' causes issues on IE. So clean children one by one with removeChild (dmstr-forks#11)
  use hasOwnProperty instead of requiring a "true" value for startval (dmstr-forks#30)
  added check for whether label is defined for checkbox (dmstr-forks#8)
  Respect "minimum"/"maximum" and "exclusiveMinimum/Maximum" (dmstr-forks#7)
  Undefined variable issue when using template (dmstr-forks#15)
  Fix typo (dmstr-forks#31)
  Fix for crash given schema {"enum":[null]} (dmstr-forks#26)
  add option for lodash templates (dmstr-forks#5)
  ...
@loganvolkers
Copy link
Contributor

We should probably provide some docs in the readme or elsewhere to indicate the state of the various github repositories and npm packages.

Personally I'd like to see this fork release a new version in the 1.0.0 range once it's ready.

@Syzygy24
Copy link

Syzygy24 commented Mar 8, 2018 •
edited

What's the new npm name gonna be?

Edit: nvm, saw that got settled since I last checked

@schmunk42
Copy link
Collaborator

Will be https://www.npmjs.com/org/json-editor/json-editor.
I think we'll start with a bunch of alpha releases, I actually would not incorporate too many changes for 1.0.0

Official 1.0.0 Release automation moved this from To do to Done Mar 9, 2018
Ruabaer pushed a commit to Ruabaer/json-editor that referenced this issue Apr 2, 2020
@Kanabanarama
Issue 488 fix disabled fields get enabled when using properties dropd…
f0cb9ee 
…own (json-editor#22)

* Check if it is always disabled before enabling any editor

* If function disable is called with param always_disabled set to true, update flag always_disabled for any editor
Ruabaer pushed a commit to Ruabaer/json-editor that referenced this issue Apr 2, 2020
@Kanabanarama @Ruabaer
Issue 488 fix disabled fields get enabled when using properties dropd…
9850f5c 
…own (json-editor#22)

* Check if it is always disabled before enabling any editor

* If function disable is called with param always_disabled set to true, update flag always_disabled for any editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Official 1.0.0 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@schmunk42 @loganvolkers @Syzygy24 @roypardi