Added support for Materialize CSS and Material Icons. #17
Conversation
Is EpicEditor deprecated or why is it removed? |
|
The replacement of EpicEditor by SimpleMDE was done in master branch. Maybe @fenichelar could enlighten us. |
|
@schmunk42 @patrickberger SimpleMDE includes a toolbar to make it easy for people who don't know markdown to write markdown, EpicEditor does not. I think it makes sense to have a toolbar because json-editor makes it easy for people who don't know JSON to write JSON. Thoughts?
|
|
I haven't looked to deep into the code, but ideally we can add editors via https://github.com/dmstr-forks/jdorn-json-editor#custom-editor-interfaces instead of having While we can deprecate features here and there, we should be able to maintain BC. Would it be possible to remove EpicEditor and SimpleMDE from the core and add it via custom editor interfaces? |
|
It's been awhile since I looked at json-editor (over a year), but if I recall correctly, I made a simple swap from EpicEditor to SimpleMDE because SimpleMDE has a toolbar and there was a bug with EpicEditor when the data was undefined. See jdorn/json-editor#667. It looks like this is a fork of a fork of a fork so I am not sure how my commit got here. I think that this PR should be limited in scope as much as possible. @schmunk42 As far as removing EpicEditor and SimpleMDE, again, I think that should be separated from this PR as it is out of scope. @patrickberger Can you remove my commits from this PR? It looks like they were already merged in this fork anyways. |
|
@fenichelar, @schmunk42 I removed my merge from master. Could you please check if this is ok? I am new to git and it took me some time and reading. |
* commit '27b611a766daf680f60f8b14779284bd9775175c': (44 commits) Added selenium tests with mocha Revert "Merge branch 'mehmetb-master' into develop" Include expanded schemas options to include refs (#27) Add option to have info buttons (#24) Implemented template support for 'rel' property on href's schema #606 (#17) Update multiple.js (#21) Fixed to expand refs before creating root editor (#18) fix for issue 627 - selectize dropdown causes prop to dissapear - and issue 538 - create hardcoded to true (#19) Issue 488 fix disabled fields get enabled when using properties dropdown (#22) Resolved merge conflicts update submitted json when editing select fields via json manually to (#29) Copy Array Element Button (#4) Cleaning with innerHTML='' causes issues on IE. So clean children one by one with removeChild (#11) use hasOwnProperty instead of requiring a "true" value for startval (#30) added check for whether label is defined for checkbox (#8) Respect "minimum"/"maximum" and "exclusiveMinimum/Maximum" (#7) Undefined variable issue when using template (#15) Fix typo (#31) Fix for crash given schema {"enum":[null]} (#26) add option for lodash templates (#5) ...
|
I've merged several PRs on CC: @loganvolkers @xvaara @jdorn WDYT? |
No description provided.