-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/validation_error_placement #853
base: master
Are you sure you want to change the base?
Conversation
Danielecina
commented
Oct 30, 2020
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks backward-compatibility? | ❌ |
Tests pass? | ✔️ |
Fixed issues | comma-separated list of tickets # fixed by the PR, if any |
Updated README/docs? | ✔️ |
Added CHANGELOG entry? | ✔️ |
* update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * Update validation.json * Update validation.json * Update validation.json * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): avanzamento * Update CHANGELOG.md * Update src/themes/bootstrap4.js * update(BMP-345): avanzamento * Update src/defaults.js * update(BMP-345): avanzamento * update(BMP-345): avanzamento * update(BMP-345): readme & constants Co-authored-by: Daniele <daniele.cina@makeitapp.eu> Co-authored-by: Federico Maggi <7142570+fredmaggiowski@users.noreply.github.com>
…h-master Align with json editor master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are onfOf
errors handled, since they are currently displaying above the form?
Fix merge with master
remove line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, could you explain with details what is the goal and how are you trying to achieve it?
I cloned your repo and tried to display error messages in differently but nothing changed.
Maybe with a example schema or better with a test? :)
Currently work as in this example With this changes i have the errors below the field and not outside of area |