Ignore unnamed literals in structs #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarredhawkins
commented
Oct 29, 2019
| @@ -341,7 +341,7 @@ func describeStruct(ctx *ctx, typ reflect2.Type) *StructDescriptor { | |||
| if ctx.onlyTaggedField && !hastag && !field.Anonymous() { | |||
| continue | |||
| } | |||
| if tag == "-" { | |||
| if tag == "-" || field.Name() == "_" { | |||
There was a problem hiding this comment.
If needed I can add another flag to ConfigCompatibleWithStandardLibrary to prevent changing the behaviour here for existing clients, which would also allow for them to still have access to these fields.
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=========================================
- Coverage 86.88% 86.49% -0.4%
=========================================
Files 41 41
Lines 5102 5102
=========================================
- Hits 4433 4413 -20
- Misses 533 553 +20
Partials 136 136
Continue to review full report at Codecov.
|
zhenzou
pushed a commit
to zhenzou/jsoniter
that referenced
this pull request
Feb 2, 2022
Ignore unnamed literals in structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves: #415
demo of bug: https://play.golang.org/p/QbqGl3ztXGs