-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLD WG feedback on JSON-LD and API #254
Comments
Minor detail: Marios wrote:
I respectfully disagree. Having both of these properties in a Linked Data definition makes the pedagogical point that having URIs is not good enough; they need to be HTTP-resolvable URIs. I think JSON-LD was merely following/echoing TBL's LD definition here. John S. Erickson, Ph.D. |
and remove the part "in the case of JSON-LD this is the base location of the document" since we now also have @base.
Suggestion 9.3.S1 has already been fixed in another commit. |
@gkellogg @msporny @dlongley @niklasl I think I've addressed all uncontroversial concerns. The remaining suggestions in the list above need further discussion IMO. Maybe we can do it directly here in the issue tracker. Syntax: 0.S0: Do nothing. We discussed this often enough already API: 1.S1: API spec is not the right place to do so |
I have taken @lanthaler's thoughts on the JSON-LD Syntax document, added mine into the mix, and tried to accurately represent the consensus over the last few weeks. I think all changes that need to be made have been made to the JSON-LD Syntax document: http://lists.w3.org/Archives/Public/public-rdf-comments/2013Jul/0038.html @lanthaler, if you could make the rest of the appropriate edits to the JSON-LD API document we can close this issue and do an official response to Marios. |
My thoughts on the remaining API issues are aligned with @lanthaler - so +1 to what he said: 1.S1: API spec is not the right place to do so |
I think there's nothing left, or is there? |
We just all need to agree on 1.S1 and 1.S3. I think we do. The boxes aren't checked. I didn't feel that I should do so since you, Dave, and Gregg know more about the API spec than I do at this point. Bottom line: If there is no disagreement on 1.S1 and 1.S3, we're done. One of us needs to respond to Marios, point-by-point, about the API spec like I did here (for the Syntax spec): http://lists.w3.org/Archives/Public/public-rdf-comments/2013Jul/0038.html Once we do that, we'll do an official response referencing both e-mails about Syntax and API and we can close the issue (in both issue trackers) if there are no objections from him. |
I’ve just responded point-by-point to the comments about the API spec: http://lists.w3.org/Archives/Public/public-rdf-comments/2013Jul/0045.html @msporny, will you send out the official response? |
Agree with @msporny's comments on API 1.S1 and 1.S3, but I think we're done anyway. |
Closing the issue here on GitHub. We have a duplicate in the RDF issue tracker which will be used to send the official response. |
_Feedback by Marios Meimaris on behalf of the Government Linked Data (GLD) Working Group_
This is a duplicate of RDF-ISSUE-135. The reason why I also created a GitHub issue is to keep track of related commits and be able to create a checkboxes for each raised point.
Hello all,
On behalf of the Government Linked Data (GLD) Working Group, I am
sending out two brief reviews for the JSON-LD and the JSON-LD Processing
Algorithms and API specifications. We are sorry for the late feedback.
Overall, the documents are well written, concise and well-structured.
Included in this email are some minor editorial fixes and
suggestions**that should benefit readability.
Congratulations to the people that worked on these!
Note: The structure of these reviews follows the original docs'
sections. Suggestions are written in the form "[section
number].S[suggestion number]".
JSON-LD 1.0 (http://www.w3.org/TR/2013/WD-json-ld-20130411/)
_0. Abstract_
RDF-inclined people will be how JSON-LD is related to RDF and when
JSON-LD is a better choice for deploying LD.
Consider adding "...but is not designed to compete with RDF, rather than
complement the shortcomings of RDF syntaxes when it comes to web-based
programming, web development and JSON-based data stores."
_1. Introduction_
guidelines", as "technique" is not a very broad term in its definition.
name/identify things..." as they are esentially talking about the same
thing.
once in the document, as inexperienced people can get confused,
especially if they are inclined to expect the use of "URI" instead of
"IRI". Provide a link to the LD Glossary.
Something like:
"...the terms IRI (https://dvcs.w3.org/hg/gld/raw-file/default/glossary/index.html#internationalized-resource-identifier)
and URI (https://dvcs.w3.org/hg/gld/raw-file/default/glossary/index.html#uniform-resource-identifier) are usually used interchangeably among Working Groups and technical
communities in general."
dereferenceable."
be in the same domain. Consider changing to
"4) the data expresses links to data on other Web sites. " to "Part of
the data contains links to external web sites."
_2. Design Goals and Rationale_
isn't, essentially, a JSON document, but is something that is
compatible. Perhaps change to something like "A JSON-LD document is
always a valid JSON document...."
simple transition from existing JSON document supporting systems..."
for better phrasing.
_3. Terminology_
identify things that are being described in the document, with IRIs,
blank node identifiers etc...."
string value."
RDF as far as Named Graphs are concerned? Don't forget that a lot of
people reading the document are RDF people and are biased toward
identifying similar notions.
Add something like "...Note that JSON-LD graphs are not the same as
RDF graphs, as they can be identified by blank node IRIs."
_5. Basic Concepts_
cases may require different handling."
shared or transferred between domains should consider absolute instead
of relative IRIs."
_A. Data Model_
graphs are removed when flattening, instead of minting IRIs? This would
give the modeller some freedom to include graphs that are not meant to
be published yet as LD.
_C. Relationship to RDF_
document or link to it from the introduction, prompting the RDF-literate
reader to consult this section before proceeding.
End of JSON-LD 1.0 Review
JSON-LD 1.0 Processing Algorithms and API
(http://www.w3.org/TR/2013/WD-json-ld-api-20130411/)
Overall, the document is concise, well structured and thorough. I've
taken the liberty to point out some really minor grammar and typo fixes.
_0. Abstract_
transformations..." (add "to")
_4. General Terminology_
identifiers for JSON-LD named graphs and RDF named graphs here?
some other absolute IRI;..." (add "to")
value (i.e. true or false)..."
_8.3 IRI Compaction_
(add "to")
context..." (add "are")
_8.5 Value Compaction_
@id
memberand, if the container....." (remove excess "of" and remove excess "if")
_9.2 Node Map Generation_
"replace" to "replaced")
_9.3 Generate Blank Node Identifier_
identifiers or..." (replace "if" with "whether" and "two" with "to")
_10.1 Convert to RDF Algorithm_
algorithm." (add "to")
"Generate a node map according to the Node
Map Generation algorithm." (add "to")
_10.6 Data Round Tripping_
converted to..." (replace "itself" with "themselves")
END OF JSON-LD 1.0 Processing Algorithms and API review
Kind regards,
Marios Meimaris
The text was updated successfully, but these errors were encountered: