Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground button css fixed #423

Closed
wants to merge 4 commits into from
Closed

Playground button css fixed #423

wants to merge 4 commits into from

Conversation

ivikash
Copy link
Contributor

@ivikash ivikash commented Aug 3, 2016

Hey,

The text in button's of playground didnt feel right, with this PR I intend to fix the padding issue

Before
screen shot 2016-08-03 at 3 21 00 pm

After
screen shot 2016-08-03 at 3 28 31 pm

@dlongley
Copy link
Member

dlongley commented Aug 3, 2016

If this kind of problem needs to be fixed, it should have some kind of bootstrap fix; I don't think we should start doing custom CSS for it.

@ivikash
Copy link
Contributor Author

ivikash commented Aug 3, 2016

Infact at first I thought the same. Lets make it generic. but then the form inside gist started breaking. So what I will do is, I will fix those in bootstrap.css itself :)

@dlongley
Copy link
Member

dlongley commented Aug 3, 2016

If we need to upgrade bootstrap, that's fine, but let's not make changes to bootstrap.css unless they are the types of fixes that would be submitted to that project directly. We should be able to use vanilla bootstrap properly to get a nice looking site.

@ivikash
Copy link
Contributor Author

ivikash commented Aug 3, 2016

Updated changes
screen shot 2016-08-03 at 11 48 06 pm

#page-playground .btn {
height: 30px;
padding: 0 0.7em;
}
Copy link
Member

@dlongley dlongley Aug 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, there wouldn't be anything custom required here at all. If the buttons still look wrong, we must not be doing something quite right with bootstrap. Their default theme looks just fine (and we're trying to use that, AFAIK).

@gkellogg
Copy link
Member

gkellogg commented Mar 2, 2017

This PR is languishing, we should either commit to close.

cc/ @msporny @davidlehn @dlongley @lanthaler.

@gkellogg gkellogg closed this Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants