New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #38. Stubs Conformance. #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to make actual definition references using data-cite
for these terms. The JSON-LD spec created a "Definitions" section and defined the imported terms locally, which were themselves references. Might want to do something similar for consistency.
E.g.:
<dt><dfn data-cite="JSON-LD11#dfn-json-ld-document">JSON-LD document</dfn></dt><dd>
A <a>JSON-LD document</a> is a serialization of
an <a>RDF dataset</a>.
See the <a data-cite="JSON-LD11#json-ld-grammar">JSON-LD Grammar</a> section in JSON-LD 1.1 for a formal description.
</dd>
These are defined in https://github.com/w3c/json-ld-wg/blob/main/common/terms.html and used with some clever code which tries to only define those terms actually used. I'm not proposing that we do that here, or that we use the local definition for for imported terms, necessarily, but structure them similarly.
I suggest to do this referencing job in a subsequent editorial PR once the referenced terms are consolidated
IIUC, in json-ld there are copy-pasted definitions from other documents. Is that correct? In my recent ramblings on other specs I spent a good amount of time replacing copied definitions with hrefs to make them coherent with the latest HTTP spec (RFC9110): this work would have been easier if they just used hrefs :) WDYT? |
Not exactly, consider the term "JSON object". It has an entry in the dl for Terms imported from Other Specifications, but the key is a reference to RFC8259. But, by defining a dfn for this, we can simply use |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@@ -262,7 +262,7 @@ <h2>Introduction</h2> | |||
The terms YAML, "YAML document", "YAML representation graph", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"YAML document" has been carefully edited out of most of this document, so perhaps it should be removed here as well?
The terms YAML, "YAML document", "YAML representation graph", | |
The terms YAML, "YAML representation graph", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ioggstream I'll hold off on merging this until you've responded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original text is ok to me. Let me just rebase the PR @gkellogg :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is merged, thanks.
This PR was discussed in the 2022-07-06 meeting, and it was agreed to merge. |
This PR
Preview | Diff