Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clampDateTime to not rely on . for timezone #765

Conversation

Lewiscowles1986
Copy link
Contributor

Similarly to how you read dates actually (permissive, rather than strictly spec-compliant) I'm using substr rather than token splitting. I Also feel like this reads a bit better, but that could be author preference.

Should fix #764

Copy link
Member

@pateketrueke pateketrueke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@pateketrueke pateketrueke merged commit 1c9095c into json-schema-faker:develop Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[possible bug] Error when consuming "valid" swagger
2 participants