Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form '*' generate only remain keys from schema #748

Closed
wants to merge 3 commits into from
Closed

form '*' generate only remain keys from schema #748

wants to merge 3 commits into from

Conversation

ErfanNaz
Copy link

@ErfanNaz ErfanNaz commented Aug 2, 2016

Description

Add your description here

Fixes Related issues

  • add related
  • issues here

Checklist

  • I have read and understand the CONTRIBUTIONS.md file
  • I have searched for and linked related issues
  • I have created test cases to ensure quick resolution of the PR is easier
  • I am NOT targeting main branch
  • I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

  • it is now possible to add custom keys to the form and add '...' for the remaining keys

- it is now possible to add costum keys to the form and add '*' for the remain keys
@Anthropic
Copy link
Member

@illiano thanks for taking the time to make a PR I really appreciate it!
I was wondering if perhaps '...' may be a better identifier for 'rest' so the * can remain as it is, would that be a hard change to make to your PR?

@Anthropic
Copy link
Member

@illiano thanks for the update, there's two things now that would get this merged quicker:

  1. documentation update, I would have to find time to update the documentation before merging, if you can help with that I'd appreciate it, just needs to spell out behaviour so a user knows that it will only add fields not already added at the order position of where the '...' is added (assuming that's what it does?)

  2. if you could make a plunker to show it in action?
    Without a test case it would be nice to be able to ensure it is stable without having to do that myself, would really appreciate your time if you can help with that :)

Otherwise I will do my best to get this merged soon :)

@Anthropic Anthropic added this to the 1.0.0 milestone Sep 28, 2016
@Anthropic Anthropic self-assigned this Sep 28, 2016
@ErfanNaz
Copy link
Author

ErfanNaz commented Sep 30, 2016

I have created a plunker, where you can see the changes in action.

https://plnkr.co/edit/Am6G772NBnHVcuZ4xQB0?p=preview

I think it's better, when you update the documentation :-)

@Anthropic
Copy link
Member

@illiano I'm not sure the plunker is working, I changed the form to be:

  $scope.form = [
    "name",
    "...",
    "comment"
  ];

And the form renders
"name",
"name",
"email",
"comment",
"comment"

Which is the same output as just using "*", is something missing?

@ErfanNaz
Copy link
Author

ErfanNaz commented Oct 3, 2016

i have fixed the bug.

@Anthropic
Copy link
Member

Great, thank you very much @illiano I will merge once I make the same changes to the webpack branch hopefully I will have time tonight, then I will look at adding documentation for it.

Anthropic added a commit to json-schema-form/json-schema-form-core that referenced this pull request Jan 24, 2017
@Anthropic Anthropic closed this Feb 18, 2017
@Anthropic
Copy link
Member

@illiano this is in the alpha :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants