Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Add new json-schema-validator library to the list of implementations #532

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

OptimumCode
Copy link
Contributor

@OptimumCode OptimumCode commented Aug 2, 2023

Hi, this is a library that I am working on and I was hoping you can add it to the list of the implementations on your website.

If the library does not meet some requirements in order to be added, please let me know. I will try my best to meet them

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for condescending-hopper-c3ed30 ready!

Name Link
🔨 Latest commit afebf6b
🔍 Latest deploy log https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/64ca0c0e768bc700070d2518
😎 Deploy Preview https://deploy-preview-532--condescending-hopper-c3ed30.netlify.app/implementations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gregsdennis
Copy link
Member

Thanks for the contribution!

If you can, please also have a look at Bowtie. It runs implementations against the official JSON Schema Test Suite. (It's also still under development, but it's functional.)

@OptimumCode
Copy link
Contributor Author

Thank you, @gregsdennis, I will.
I already set up the official test-suites for running them locally as a part of the CI. But I will try to integrate Bowtie as well

@gregsdennis
Copy link
Member

Bowtie is a system you'll integrate your implementation into. There are instructions, but basically you'll create a runner that Bowtie can use to run your implementation. Then you'll submit that to Bowtie.

It's not necessary for this, though.

@OptimumCode
Copy link
Contributor Author

OptimumCode commented Aug 2, 2023

It's not necessary for this, though.

I understand that) But it looks cool to have a statistic for all different implementations in one place

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! =]
Best of luck on completing the implementation to be fully compliant.
Please feel free to come join our slack and ask questions.
Looks like you found Bowtie. Do add your implementation there if you are able.

@gregsdennis gregsdennis merged commit 4e1a8b7 into json-schema-org:main Aug 2, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants