Support for IRI references #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Relequestual @handrews I have pushed commits changing URIs to IRIs in the spec as well where necessary. I left references to RFC 3986 (URIs) wherever resolving base URIs is mentioned, as this is also applicable to IRIs and RFC 3987 actually refers to RFC 3986 in this manner. I would therefore like to resume discussions about merging this. @jdesrosiers I fixed the commit history, which closed #1068. |
Relequestual
approved these changes
Oct 15, 2021
|
Assuming there are impacts for testing. |
|
There's a draft-future directory which we now have in the repo which represents tests already-written for a not-yet-released draft, so it can go there certainly. Otherwise a bug ticket is also fine! |
jdesrosiers
approved these changes
Oct 18, 2021
12 tasks
karenetheridge
added a commit
to karenetheridge/json-schema-spec
that referenced
this pull request
Jan 7, 2022
Merged
jdesrosiers
pushed a commit
to jdesrosiers/json-schema-spec
that referenced
this pull request
Jun 30, 2022
* Change URIs to IRIs where appropriate
jdesrosiers
pushed a commit
to jdesrosiers/json-schema-spec
that referenced
this pull request
Jun 30, 2022
jdesrosiers
pushed a commit
to jdesrosiers/json-schema-spec
that referenced
this pull request
Jun 30, 2022
* Change URIs to IRIs where appropriate
jdesrosiers
pushed a commit
to jdesrosiers/json-schema-spec
that referenced
this pull request
Jun 30, 2022
jdesrosiers
pushed a commit
that referenced
this pull request
Jul 8, 2022
* Change URIs to IRIs where appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would add support for IRI references in $id, $ref and $dynamicRef as per #59.
This PR fixes history of #1068.