Allow boolean subschemas everywhere. #128
Conversation
|
Added a commit that puts JSON Reference in the meta-schema. This addition does not change any specified behavior at all, it just further brings the meta-schema in line with the latest draft. I added it here because it was easier than having to merge two different subschema fixes. |
handrews
force-pushed
the
bool
branch
2 times, most recently
from
fe7f820
to
da0ab16
Compare
|
@awwright @Relequestual any concerns holding this up? |
|
lgtm as a side comment - we are on the right path of differentiating schemas and subschemas :) |
| "anyOf": [ | ||
| {"$ref": "#"}, | ||
| {"type": "boolean"}, | ||
| {"$ref": "http://json-schema.org/draft/hyper-schema#/definitions/jsonReference"} |
There was a problem hiding this comment.
I think it should be http://json-schema.org/draft/schema#/definitions/jsonReference
There was a problem hiding this comment.
Good catch, thanks! Fixed.
| @@ -3,10 +3,24 @@ | |||
| "$schema": "http://json-schema.org/draft/schema#", | |||
| "description": "Core schema meta-schema", | |||
| "definitions": { | |||
| "jsonReference": { | |||
There was a problem hiding this comment.
Shouldn't the property "$ref" be required?
There was a problem hiding this comment.
Yeah, I'll fix that, thanks!
This is one alternative for issue json-schema-org#101. If accepted, the meta-schema change will come separately after PR json-schema-org#168 is merged.
|
@awwright @Relequestual @epoberezkin I have taken the meta-schema changes out of this and will re-add once PR #168 is accepted, at which point the changes will be simpler. I will do the same with PR #167 (the version of this that includes root schemas), which I definitely prefer to this version now. So if there's any consensus on that please comment so I can close this version. |
| @@ -189,7 +189,7 @@ | |||
| <t> | |||
| A JSON Schema document, or simply a schema, is a JSON document used to describe an instance. | |||
| A schema is itself interpreted as an instance. | |||
| A JSON schema MUST be an object. | |||
| A JSON Schema document MUST consist of an object, known as the root schema. | |||
| </t> | |||
There was a problem hiding this comment.
This language is not correct. "Consists of" means "has parts". Previous "must be" is correct.
| @@ -535,12 +532,11 @@ | |||
| </t> | |||
| <t> | |||
| This keyword's value MUST be an object. Each property specifies a dependency. | |||
| Each dependency value MUST be an object or an array. | |||
| Each dependency value MUST be an array or a valid subschema. | |||
| </t> | |||
There was a problem hiding this comment.
I would add "array of strings"?
There was a problem hiding this comment.
That's covered on line 542.
|
#167 was used instead. |
This implements issue #101