-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename implementations section to tools #321
Conversation
Deploying with
|
Latest commit: |
c55e0cc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2b360dd0.website-2v2.pages.dev |
Branch Preview URL: | https://benjagm-tools-rename.website-2v2.pages.dev |
Thanks! |
The url is the same. I just renamed the title/buttons. |
We should also do https://json-schema.org/obsolete-implementations |
I just pushed the change to rename that page as well. |
OK. I'm fine with this if we also create a new good first issue to clean up the rest of the site to use "tools" rather than "implementations" everywhere but the spec documents (because we don't change those. I think that would accurately reflect what we want to see. And in the code, to make it less confusing. |
Also consider that the spec does need to define its term for "implementation". I still think that it needs to be "software that performs the tasks defined in the spec", which are just validation and annotation. |
Hello @benjagm I was going through the preview for this branch but I still see that we have implementations term being used in the body of the Tools at a lot of places, I was wandering, should that be done in a different PR?? |
Hey. Yes. See #321 (comment) =] |
cool @Relequestual i will create one then that covers handling use of all the implementations term usage |
@praveen-rikhari Please reference this issue when you do. Thanks. |
GitHub Issue: #320
Resolves: #320
Summary: This PR renames the Implementations section in favour of Tools
Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)
No