Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename implementations section to tools #321

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Rename implementations section to tools #321

merged 2 commits into from
Feb 26, 2024

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Feb 20, 2024

GitHub Issue: #320
Resolves: #320

Summary: This PR renames the Implementations section in favour of Tools

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No

Copy link

cloudflare-pages bot commented Feb 20, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c55e0cc
Status: ✅  Deploy successful!
Preview URL: https://2b360dd0.website-2v2.pages.dev
Branch Preview URL: https://benjagm-tools-rename.website-2v2.pages.dev

View logs

@Relequestual
Copy link
Member

Thanks!
How do we plan to handle redirects?

@benjagm
Copy link
Collaborator Author

benjagm commented Feb 20, 2024

Thanks! How do we plan to handle redirects?

The url is the same. I just renamed the title/buttons.

@Relequestual
Copy link
Member

We should also do https://json-schema.org/obsolete-implementations
Happy if you want that to be a separate PR, but I think it could be in this one.

@benjagm
Copy link
Collaborator Author

benjagm commented Feb 20, 2024

We should also do https://json-schema.org/obsolete-implementations
Happy if you want that to be a separate PR, but I think it could be in this one.

I just pushed the change to rename that page as well.

@Relequestual
Copy link
Member

OK. I'm fine with this if we also create a new good first issue to clean up the rest of the site to use "tools" rather than "implementations" everywhere but the spec documents (because we don't change those. I think that would accurately reflect what we want to see.

And in the code, to make it less confusing.

@gregsdennis
Copy link
Member

everywhere but the spec documents (because we don't change those.

Also consider that the spec does need to define its term for "implementation". I still think that it needs to be "software that performs the tasks defined in the spec", which are just validation and annotation.

@praveen-rikhari
Copy link
Contributor

Hello @benjagm I was going through the preview for this branch but I still see that we have implementations term being used in the body of the Tools at a lot of places, I was wandering, should that be done in a different PR??

@praveen-rikhari
Copy link
Contributor

Screenshot from 2024-02-22 12-17-38
Screenshot from 2024-02-22 12-17-48
Screenshot from 2024-02-22 12-18-00

Here are some of them

@Relequestual
Copy link
Member

Hello @benjagm I was going through the preview for this branch but I still see that we have implementations term being used in the body of the Tools at a lot of places, I was wandering, should that be done in a different PR?? - @praveen-rikhari

Hey. Yes. See #321 (comment) =]
You are welcome to create the new Issue if you like.

@praveen-rikhari
Copy link
Contributor

cool @Relequestual i will create one then that covers handling use of all the implementations term usage

@Relequestual
Copy link
Member

@praveen-rikhari Please reference this issue when you do. Thanks.

@benjagm benjagm merged commit 00cf134 into main Feb 26, 2024
1 check passed
@benjagm benjagm deleted the benjagm-tools-rename branch February 26, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Implementations by Tools
4 participants