New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid instantiation of JBool #626

Merged

xuwei-k merged 2 commits into json4s:master from yanns:avoid_JBool_instances

Oct 14, 2019

Contributor

yanns commented Oct 10, 2019

No description provided.


          avoid instantiation of JBool

xuwei-k requested changes

View reviewed changes

Member

xuwei-k left a comment

[error] /home/travis/build/json4s/json4s/ast/src/main/scala/org/json4s/JsonAST.scala:142:14: method apply is defined twice
[error]   conflicting symbols both originated in file '/home/travis/build/json4s/json4s/ast/src/main/scala/org/json4s/JsonAST.scala'
[error]   case class JBool(value: Boolean) extends JValue {
[error]              ^
[error] two errors found


          force scala 2.11 to consider source as from 2.12 to allow overriding …

5d9651d

…apply method

xuwei-k approved these changes

View reviewed changes

xuwei-k merged commit 60f84e1 into json4s:master

yanns deleted the avoid_JBool_instances branch

October 14, 2019 08:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet