Support builtin functions and nested classes #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davvid
added a commit
that referenced
this pull request
Jun 16, 2018
* mstimberg/builtins_and_nested: Support encoding/decoding builtin functions Support encoding/decoding nested classes Closes #176 Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #192, this PR adds support for nested class definitions (for Python >=3.3) and for builtin functions such as
dir. It fixes several examples mentioned in that issue, but I am not sure whether it does actually help for the problem withKNeighborsClassifierthat the OP had.Closes #176 (which I did not actually see before working on this). Although I'm not sure whether you want to consider it closed given that it only works with Python >= 3.3.