Python 3.8 #292
Python 3.8 #292
Conversation
Signed-off-by: David Aguilar <davvid@gmail.com>
tox's verbose flag is "-v", not "--verbose". Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Python3.8 now returns file descriptors as io.TextIOWrapper objects. Add a custom handler that drops these to None. Closes jsonpickle#281 Signed-off-by: David Aguilar <davvid@gmail.com>
|
Did you forget to add Lines 4 to 9 in a52ba42 |
Signed-off-by: David Aguilar <davvid@gmail.com>
|
@hartwork thanks for the heads-up. I just added it -- wasn't sure if travis supported it yet. |
Signed-off-by: David Aguilar <davvid@gmail.com>
| @@ -7,8 +7,9 @@ python: | |||
| # - "3.5" # ecdsa tests fail in 3.5. | |||
| - "3.6" | |||
| - &latest_py3 "3.7" | |||
| - "3.8" | |||
There was a problem hiding this comment.
Are you aware that now latest_py3 no longer points to the latest Python 3?
There was a problem hiding this comment.
Yeah, I did that on purpose. python3.8 is so new that I didn't trust twine and the deployment steps to work in that environment. My not-great metric is that py3.8 required code updates for JP itself, and we're not even that big of a library, so I opted to hold that back for stability purposes.
We'll update that eventually, though. Thanks for the heads-up.
There was a problem hiding this comment.
I think it would be easy to change the variable name latest_py3 to something less mis-leading in the mean time. Just an idea.
Add support for Python 3.8.