Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add a test suite for sklearn objects #344

Merged
merged 5 commits into from Jan 18, 2021
Merged

Conversation

davvid
Copy link
Member

@davvid davvid commented Jan 18, 2021

Add the test recipe from #155 to demonstrate that
sklearn DecisionTreeClassifier objects can be properly
serialized.

This behavior was originally fixed in #170.

Closes #155
Signed-off-by: David Aguilar davvid@gmail.com

Signed-off-by: David Aguilar <davvid@gmail.com>
Register dictionaries as eligible for referencing.  Ensure that
dictionary identity is preserved across a roundtrip.

Closes jsonpickle#255
Signed-off-by: David Aguilar <davvid@gmail.com>
* davvid/dict-references:
  serialization: preserve dictionary identity when un/pickling
  tests/jsonpickle_test: use pytest for standalone execution

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Add the test recipe from jsonpickle#155 to demonstrate that
sklearn DecisionTreeClassifier objects can be properly
serialized.

This behavior was originally fixed in jsonpickle#170.

Closes jsonpickle#155
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid merged commit 6b727ff into jsonpickle:master Jan 18, 2021
@davvid davvid deleted the sklearn branch January 18, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scikit learn decision tree gets unpickled as dictionary
1 participant