Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor speedup for _get_flattener on complex objects #349

Merged
merged 6 commits into from Feb 4, 2021
Merged

Minor speedup for _get_flattener on complex objects #349

merged 6 commits into from Feb 4, 2021

Conversation

Theelx
Copy link
Contributor

@Theelx Theelx commented Jan 31, 2021

Sped up _get_flattener (part of the Pickler) by merging the tuple and set checks. Performance increases most notably if encoding many tuples, sets, or other non-list/dict objects.

@Theelx
Copy link
Contributor Author

Theelx commented Jan 31, 2021

Don't merge just yet -- more improvements coming. I should have made this a draft pull request, sorry.

@Theelx
Copy link
Contributor Author

Theelx commented Feb 1, 2021

Ok, I think that's all. It's ready to merge once checks are completed with travis.

@Theelx
Copy link
Contributor Author

Theelx commented Feb 1, 2021

Sorry I'm really bad with git. Or any workflow tool to be honest, coding is more of a hobby for me lmao.

@davvid
Copy link
Member

davvid commented Feb 1, 2021

It's all good, I don't mind seeing your works-in-progress.

What platform are you on? If you need a recommendation for a nice git gui which might help with visualizing your edits, I won't be shy about recommending the best one around. 😄

I would suggest doing a rebase after you've got it all nice and committed, but you can always save that stuff for the end. Rebasing will let you pick up stuff that's been pushed upstream. (sorry, you probably already know that)

...

I like to joke that my "2nd gig" is a "git trainer" since everyone tends to come to me with their git questions, so I tend go into "git helper mode" when someone says they're not familiar with git. I'm happy to help if you have any questions.

@Theelx
Copy link
Contributor Author

Theelx commented Feb 1, 2021

Actually, I had no clue what rebasing was, so thanks! I'll try out git cola, meanwhile this is all ready for merging.

@Theelx
Copy link
Contributor Author

Theelx commented Feb 3, 2021

@davvid Can this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants