Remove DemJSON Test #374
Remove DemJSON Test #374
Conversation
DemJSON doesn't support CPython 3.9+. It'd be worth considering dropping its backend, as DemJSON itself hasn't been updated since 2015.
Globals should be avoided usually, but unittest doesn't seem to let us access nn-globals in the skipIf decorator.
Apparently unittest lets you skip conditionally inside the test itself!
Apparently some test cases don't call set_backend, so check if it's been called first.
I guess set_backend isn't called, it's always set_preferred_backend???
DemJSON hasn't been updated since December 2015, which is 6 years ago now. It should be safe to drop support, especially since there are many other faster backends supported, like ujson.
|
@davvid I'm in the process of fixing up all the tests and removing obsolete code. Is it okay to remove the DemJSON backend considering its last update date? Next, I plan to work on fixing the FutureWarning for the pandas tests, and fixing some DeprecationWarnings for the numpy dtype tests. |
|
I'm going to merge this, and hopefully fix the FutureWarning and DeprecationWarnings sometime this week. |
|
Users that were using demjson may have been relying on its non-standard handling of comments. It's made me wonder whether we should support yaml backends instead. (not related to this cleanup, just thinking out loud) In a sense, the core problem in jsonpickle could almost be thought of as a dictpickle, and we can support multiple ways to de/serialize from/to that dict. If users really need comments, relying on a yaml backend sounds like a better long-term solution than a non-standard json parser. Of course, if demjson ever starts getting updated then we can always revisit this decision. Thanks for cleaning out the demjson backend. |
DemJSON doesn't support CPython 3.9+. It'd be worth considering dropping its backend, as DemJSON itself hasn't been updated since 2015.