pickler: Cython 3.0 compatibility #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Cython create functions that provide a __reduce__() implementation that does not play nicely with the strategies used by jsonpickle. Detect Cython functions and record references to them directly so that they are properly pickled. This fixes the ability to encode and decode pandas objects. We avoid recording "py/ref" references to Cython functions because they throw off the ref offsets and are not needed. "py/function" references, when unpickled, resolve to module globals that exist outside of the object graph. Fixes: jsonpickle#460
Remove the Cython "py/ref" avoidance by recording ref entries when unpickling "py/function" entities. Update the unpickler to do record ref entries for "py/function" so that we can remove the hacky self._objs handling for Cython functions in the pickler. Related-to: jsonpickle#460
Cython v3 produces functions that pass the util.is_object() tests. This complicated the unpickler because it needed to start tracking refs for functions, which it never needed to do before. Expand the meaning of is_module_function() so that it includes cython functions and use this check earlier in the pickling process. This makes the pickler handle Cython functions before they ever make it into the "if util.is_object(obj):" code path. These changes restore the pickler's original semantics by ensuring that functions are excluded from the referencing machinery completely. Related-to: jsonpickle#460
davvid
changed the title
|
I split these changes up into several commits mostly to record the different approaches I encountered along the way. The first ones are kinda hacky but the later ones make things simple again. Let me know if you'd prefer that I squash them all together. |
davvid
force-pushed
the
cython-functions
branch
from
a88ee0e
to
cfcc106
Compare
davvid
changed the title
|
I believe this patch worked: https://copr.fedorainfracloud.org/coprs/churchyard/pandas2/build/7030817/ |
|
https://pypi.org/project/jsonpickle/3.0.3/ contains this fix. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.