tests: enable cache for pytest-ruff >= 0.3.0 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruff had a change in behavior that is not currently playing nice with pytest-ruff. Pin down to 0.2.x for now.
|
I'm going to take another look. I think the real error is that we're disabling pytest's cache provider, and that's causing pytest-ruff to fail because the newer versions rely on being able to store and retrieve items from the cache. I'll update this PR shortly after I make the same change over in https://github.com/git-cola/git-cola/ |
davvid
changed the title
Theelx
requested changes
Mar 12, 2024
Newer versions of pytest-ruff require a cache provider. Remove the no:cacheprovider flags to get pytest-ruff working again.
Narrow the pytest discovery to just the jsonpickle and tests directories. This speeds up pytest because it spends less time walking the directory structure looking for non-existent tests.
Theelx
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of pytest-ruff require a cache provider.
Remove the no:cacheprovider flags to get pytest-ruff working again.