Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close div in resume.hbs #15

Closed
DavidEngland opened this issue Oct 15, 2016 · 3 comments
Closed

close div in resume.hbs #15

DavidEngland opened this issue Oct 15, 2016 · 3 comments

Comments

@DavidEngland
Copy link

Should there not be a after the last partial to close the

?
@ishu3101
Copy link
Contributor

Yeah, there should be one. I forgot to close the div after I refactored the code to make use of Handelbar partials.

ciderpunx pushed a commit to ciderpunx/jsonresume-theme-boilerplate that referenced this issue Jan 7, 2017
Close div tag in resume.hbs
1d69c6c 
Fixes: jsonresume#15
@ciderpunx ciderpunx mentioned this issue Jan 7, 2017
Open
ciderpunx pushed a commit to ciderpunx/jsonresume-theme-boilerplate that referenced this issue Jan 25, 2017
Close div tag in resume.hbs
e5d101f 
With indentation per discussion thread: jsonresume#16

Fixes: jsonresume#15
@ciderpunx
Copy link

OK?

@XuluWarrior
Copy link

This issue is marked as closed but the pull request was never merged into this repository. Can we reopen it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ciderpunx @DavidEngland @ishu3101 @XuluWarrior