fix: revert language logic and introduce meta lang #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly reverts one of the changes made in #48 which makes a change that doesn't completely adhere to the JSON Resume spec.
The JSON Resume spec expects languages to be defined using a natural language name, not a language code. Using this properly differently is expected and ultimately makes this incompatible with other themes which defeats the point of the standard.
Instead, we'll use a custom property in
metathat users can choose to use.Does the following:
meta.languageto set the document language.<head>section of the template a lot more defensive, as every field is optional.