Merge pull request #95 from jsonresume/feature/fix-linting

fix: linting
jsonresume · May 24, 2024 · f60a1aa · f60a1aa
2 parents ef3d7c6 + 985ad9a
commit f60a1aa
Show file tree

Hide file tree

Showing 24 changed files with 268 additions and 395 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/apps/homepage2/.eslintrc.js b/apps/homepage2/.eslintrc.js
@@ -1,21 +1,11 @@
 module.exports = {
-  parser: '@babel/eslint-parser',
-  extends: ['eslint:recommended', 'plugin:react/recommended', 'next'],
-  parserOptions: {
-    ecmaVersion: 2021,
-    sourceType: 'module',
-    ecmaFeatures: {
-      jsx: true,
-    },
-    requireConfigFile: false,
-  },
-  plugins: ['react'],
+  extends: ['custom', 'next'],
   rules: {
     '@next/next/no-html-link-for-pages': 'off',
   },
-  settings: {
-    react: {
-      version: 'detect',
-    },
+  env: {
+    browser: true,
+    es2021: true,
+    jquery: true,
   },
 };
diff --git a/apps/homepage2/package.json b/apps/homepage2/package.json
@@ -44,6 +44,7 @@
     "react-autocomplete": "^1.8.1",
     "react-dom": "^18.2.0",
     "react-markdown": "^8.0.7",
+    "react-syntax-highlighter": "^15.5.0",
     "remark": "^15.0.1",
     "remark-html": "^16.0.1",
     "resume-schema": "^1.0.0",
@@ -52,13 +53,11 @@
     "uuid": "^9.0.0"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
     "@types/node": "^20.10.0",
     "caniuse-lite": "^1.0.30001566",
     "eslint": "^8.55.0",
     "eslint-config-custom": "workspace:*",
     "eslint-config-next": "^14.0.3",
-    "eslint-plugin-react": "^7.33.2",
     "typescript": "^5.3.2"
   }
 }
diff --git a/apps/registry/package.json b/apps/registry/package.json
@@ -92,14 +92,12 @@
     "uuid": "^9.0.0"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
     "@playwright/test": "^1.40.0",
     "@types/node": "^20.10.0",
     "caniuse-lite": "^1.0.30001566",
     "eslint": "^8.55.0",
     "eslint-config-custom": "workspace:*",
     "eslint-config-next": "^14.0.3",
-    "eslint-plugin-react": "^7.33.2",
     "playwright": "^1.40.0",
     "typescript": "^5.3.2"
   }

diff --git a/eslint.config.js b/eslint.config.js
diff --git a/package.json b/package.json
@@ -21,7 +21,6 @@
   "name": "jsonresume.org",
   "dependencies": {
     "@changesets/cli": "^2.27.1",
-    "dotenv": "^16.0.3",
-    "react-syntax-highlighter": "^15.5.0"
+    "dotenv": "^16.0.3"
   }
 }
diff --git a/packages/eslint-config-custom/package.json b/packages/eslint-config-custom/package.json
@@ -7,17 +7,15 @@
   "dependencies": {
     "eslint-config-prettier": "^8.3.0",
     "eslint-config-turbo": "^1",
-    "prismjs": "^1.29.0"
+    "eslint-plugin-react": "^7.33.2"
   },
   "publishConfig": {
     "access": "public"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
     "@typescript-eslint/eslint-plugin": "^6.13.1",
     "@typescript-eslint/parser": "^6.13.1",
     "eslint": "^8.54.0",
-    "eslint-plugin-react": "^7.33.2",
     "typescript": "^5.3.2"
   },
   "scripts": {

diff --git a/packages/jsonresume-theme-cv/.eslintrc b/packages/jsonresume-theme-cv/.eslintrc
@@ -0,0 +1,3 @@
+{
+  "extends": ["custom/react"]
+}
diff --git a/packages/jsonresume-theme-cv/package.json b/packages/jsonresume-theme-cv/package.json
@@ -5,12 +5,16 @@
   "main": "./src/index.js",
   "license": "MIT",
   "devDependencies": {
+    "eslint-config-custom": "workspace:^",
     "react": "^18",
     "styled-components": "^6"
   },
   "peerDependencies": {
     "styled-components": "^6"
   },
+  "scripts": {
+    "lint": "eslint ."
+  },
   "dependencies": {
     "prismjs": "^1.29.0",
     "react-icons": "^5.0.1"

diff --git a/packages/jsonresume-theme-flat/package.json b/packages/jsonresume-theme-flat/package.json
@@ -12,13 +12,7 @@
     "start": "resume serve"
   },
   "dependencies": {
-    "handlebars": "latest",
-    "prismjs": "^1.29.0"
+    "handlebars": "latest"
   },
-  "license": "MIT",
-  "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",
-    "eslint-plugin-react": "^7.33.2"
-  }
+  "license": "MIT"
 }
diff --git a/packages/jsonresume-theme-full/package.json b/packages/jsonresume-theme-full/package.json
@@ -25,13 +25,9 @@
   },
   "license": "MIT",
   "dependencies": {
-    "handlebars": "latest",
-    "prismjs": "^1.29.0"
+    "handlebars": "latest"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",
-    "eslint-plugin-react": "^7.33.2",
     "sass": "^1.44.0"
   }
 }
diff --git a/packages/jsonresume-theme-onepage/package.json b/packages/jsonresume-theme-onepage/package.json
@@ -17,10 +17,5 @@
     "url": "https://github.com/ainsleychong/jsonresume-theme-onepage/issues"
   },
   "homepage": "https://github.com/ainsleychong/jsonresume-theme-onepage",
-  "main": "index.js",
-  "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",
-    "eslint-plugin-react": "^7.33.2"
-  }
+  "main": "index.js"
 }
diff --git a/packages/jsonresume-theme-spartacus/package.json b/packages/jsonresume-theme-spartacus/package.json
@@ -11,12 +11,6 @@
   "license": "MIT",
   "dependencies": {
     "handlebars": "latest",
-    "moment": "^2.14.1",
-    "prismjs": "^1.29.0"
-  },
-  "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",
-    "eslint-plugin-react": "^7.33.2"
+    "moment": "^2.14.1"
   }
 }
diff --git a/packages/jsonresume-theme-standard/.eslintrc b/packages/jsonresume-theme-standard/.eslintrc
@@ -0,0 +1,3 @@
+{
+  "extends": ["custom/react"]
+}
diff --git a/packages/jsonresume-theme-standard/package.json b/packages/jsonresume-theme-standard/package.json
@@ -5,13 +5,14 @@
   "main": "./src/index.js",
   "license": "MIT",
   "devDependencies": {
+    "eslint-config-custom": "workspace:^",
     "react": "^18",
     "styled-components": "^6"
   },
   "peerDependencies": {
     "styled-components": "^6"
   },
-  "dependencies": {
-    "prismjs": "^1.29.0"
+  "scripts": {
+    "lint": "eslint ."
   }
 }
diff --git a/packages/jsonresume-theme-tailwind/.eslintrc b/packages/jsonresume-theme-tailwind/.eslintrc
@@ -0,0 +1,3 @@
+{
+  "extends": ["custom/react"]
+}
diff --git a/packages/jsonresume-theme-tailwind/package.json b/packages/jsonresume-theme-tailwind/package.json
@@ -5,24 +5,23 @@
   "main": "./src/index.js",
   "license": "MIT",
   "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",
     "eslint-config-custom": "workspace:*",
-    "eslint-plugin-react": "^7.33.2",
     "react": "^18",
     "styled-components": "^6",
     "tailwindcss": "^3.4.3"
   },
   "peerDependencies": {
     "styled-components": "^6"
   },
+  "scripts": {
+    "lint": "eslint ."
+  },
   "dependencies": {
     "@radix-ui/react-avatar": "^1.0.4",
     "@radix-ui/react-slot": "^1.0.2",
     "class-variance-authority": "^0.7.0",
     "clsx": "^2.1.1",
     "google": "link:next/font/google",
-    "prismjs": "^1.29.0",
     "react-icons": "^5.0.1",
     "server": "link:twind/shim/server",
     "tailwind-merge": "^2.3.0",

diff --git a/packages/tsconfig/package.json b/packages/tsconfig/package.json
@@ -5,13 +5,5 @@
   "license": "MIT",
   "publishConfig": {
     "access": "public"
-  },
-  "dependencies": {
-    "prismjs": "^1.29.0"
-  },
-  "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",
-    "eslint-plugin-react": "^7.33.2"
   }
 }
diff --git a/packages/ui/.eslintrc.json b/packages/ui/.eslintrc.json
diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -6,18 +6,13 @@
   "types": "./index.tsx",
   "license": "MIT",
   "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
     "@types/react": "^18",
     "@types/react-dom": "^18",
     "eslint": "^7.32.0",
     "eslint-config-custom": "workspace:*",
-    "eslint-plugin-react": "^7.33.2",
     "react": "^18",
     "tsconfig": "workspace:*",
     "typescript": "^5"
   },
-  "module": "true",
-  "dependencies": {
-    "prismjs": "^1.29.0"
-  }
+  "module": "true"
 }